![]() |
lvs-devel
|
| To: | yangxingwu <xingwu.yang@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] ipvs: remove unnecessary space |
| Cc: | wensong@xxxxxxxxxxxx, horms@xxxxxxxxxxxx, ja@xxxxxx, kadlec@xxxxxxxxxxxxxxxxx, fw@xxxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, joe@xxxxxxxxxxx |
| From: | Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> |
| Date: | Mon, 15 Jul 2019 09:57:03 +0200 |
On Fri, Jul 12, 2019 at 09:07:21PM +0800, yangxingwu wrote:
> this patch removes the extra space and use bitmap_zalloc instead
>
> Signed-off-by: yangxingwu <xingwu.yang@xxxxxxxxx>
> ---
> net/netfilter/ipvs/ip_vs_mh.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
> index 94d9d34..3229867 100644
> --- a/net/netfilter/ipvs/ip_vs_mh.c
> +++ b/net/netfilter/ipvs/ip_vs_mh.c
> @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
> return 0;
> }
>
> - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
> - sizeof(unsigned long), GFP_KERNEL);
> + table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
By doing:
git grep "= " ...
on the netfilter folders, I see more of these, it would be good if you
fix them at once or, probably, you want to use coccinelle for this.
Thanks.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [net-next 0/2] ipvs: speedup ipvs netns dismantle, Haishuang Yan |
|---|---|
| Next by Date: | Re: [PATCH] ipvs: remove unnecessary space, Pablo Neira Ayuso |
| Previous by Thread: | [PATCH] ipvs: remove unnecessary space, yangxingwu |
| Next by Thread: | Re: [PATCH] ipvs: remove unnecessary space, Pablo Neira Ayuso |
| Indexes: | [Date] [Thread] [Top] [All Lists] |