Re: [PATCH 01/26] bpfilter: fix up a sparse annotation

To:	Christoph Hellwig <hch@xxxxxx>
Subject:	Re: [PATCH 01/26] bpfilter: fix up a sparse annotation
Cc:	"David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-sctp@xxxxxxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx, linux-bluetooth@xxxxxxxxxxxxxxx, bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, dccp@xxxxxxxxxxxxxxx, linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx, linux-wpan@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, mptcp@xxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, rds-devel@xxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, tipc-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-x25@xxxxxxxxxxxxxxx
From:	Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
Date:	Thu, 23 Jul 2020 13:14:47 +0200

On Thu, Jul 23, 2020 at 08:08:43AM +0200, Christoph Hellwig wrote:
> The __user doesn't make sense when casting to an integer type, just
> switch to a uintptr_t cast which also removes the need for the __force.

Feel free to add my:

Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>

-- Luc

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 10/26] netfilter: remove the unused user argument to do_update_counters, (continued) [PATCH 10/26] netfilter: remove the unused user argument to do_update_counters, Christoph Hellwig [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Christoph Hellwig [PATCH 11/26] netfilter: switch xt_copy_counters to sockptr_t, Christoph Hellwig [PATCH 06/26] net: switch sock_setbindtodevice to sockptr_t, Christoph Hellwig [PATCH 09/26] net/xfrm: switch xfrm_user_policy to sockptr_t, Christoph Hellwig [PATCH 02/26] net/bpfilter: split __bpfilter_process_sockopt, Christoph Hellwig [PATCH 08/26] net: switch sock_set_timeout to sockptr_t, Christoph Hellwig Re: [MPTCP] [PATCH 08/26] net: switch sock_set_timeout to sockptr_t, Matthieu Baerts [PATCH 07/26] net: switch sock_set_timeout to sockptr_t, Christoph Hellwig [PATCH 01/26] bpfilter: fix up a sparse annotation, Christoph Hellwig Re: [PATCH 01/26] bpfilter: fix up a sparse annotation, Luc Van Oostenryck <= [PATCH 04/26] net: add a new sockptr_t type, Christoph Hellwig Re: [PATCH 04/26] net: add a new sockptr_t type, Jan Engelhardt Re: [PATCH 04/26] net: add a new sockptr_t type, Eric Dumazet Re: [PATCH 04/26] net: add a new sockptr_t type, Christoph Hellwig [PATCH 05/26] net: switch copy_bpf_fprog_from_user to sockptr_t, Christoph Hellwig [PATCH 03/26] bpfilter: reject kernel addresses, Christoph Hellwig RE: [PATCH 03/26] bpfilter: reject kernel addresses, David Laight Re: [PATCH 03/26] bpfilter: reject kernel addresses, 'Christoph Hellwig' RE: [PATCH 03/26] bpfilter: reject kernel addresses, David Laight Re: get rid of the address_space override in setsockopt v2, David Miller

Previous by Date:	Re: [MPTCP] [PATCH 25/26] net: pass a sockptr_t into ->setsockopt, Matthieu Baerts
Next by Date:	RE: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, David Laight
Previous by Thread:	[PATCH 01/26] bpfilter: fix up a sparse annotation, Christoph Hellwig
Next by Thread:	[PATCH 04/26] net: add a new sockptr_t type, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]