LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net-next v1 3/4] net/core: move gro function declarations to

To: Jakub Kicinski <kuba@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>
Subject: Re: [PATCH net-next v1 3/4] net/core: move gro function declarations to separate header
Cc: <coreteam@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, <lvs-devel@xxxxxxxxxxxxxxx>, Matteo Croce <mcroce@xxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <netfilter-devel@xxxxxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>
From: Leon Romanovsky <leonro@xxxxxxxxxx>
Date: Wed, 3 Feb 2021 15:22:43 +0200
On Wed, Feb 03, 2021 at 12:16:11PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Fir the following compilation warnings:
>  1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb)
>
> net/ipv6/ip6_offload.c:182:41: warning: no previous prototype for 
> ‘ipv6_gro_receive’ [-Wmissing-prototypes]
>   182 | INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct 
> list_head *head,
>       |                                         ^~~~~~~~~~~~~~~~
> net/ipv6/ip6_offload.c:320:29: warning: no previous prototype for 
> ‘ipv6_gro_complete’ [-Wmissing-prototypes]
>   320 | INDIRECT_CALLABLE_SCOPE int ipv6_gro_complete(struct sk_buff *skb, 
> int nhoff)
>       |                             ^~~~~~~~~~~~~~~~~
> net/ipv6/ip6_offload.c:182:41: warning: no previous prototype for 
> ‘ipv6_gro_receive’ [-Wmissing-prototypes]
>   182 | INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct 
> list_head *head,
>       |                                         ^~~~~~~~~~~~~~~~
> net/ipv6/ip6_offload.c:320:29: warning: no previous prototype for 
> ‘ipv6_gro_complete’ [-Wmissing-prototypes]
>   320 | INDIRECT_CALLABLE_SCOPE int ipv6_gro_complete(struct sk_buff *skb, 
> int nhoff)
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
>  include/net/gro.h | 12 ++++++++++++
>  net/core/dev.c    |  7 +------
>  2 files changed, 13 insertions(+), 6 deletions(-)
>  create mode 100644 include/net/gro.h

I sent it too fast, sorry for that.
There is a need to add #include <net/gro.h> to the ip6_offload.c.

I will resend.

Thanks

<Prev in Thread] Current Thread [Next in Thread>