LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net] ipvs: properly declare tunnel encapsulation

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [PATCH net] ipvs: properly declare tunnel encapsulation
Cc: lvs-devel@xxxxxxxxxxxxxxx, Alex Gartrell <agartrell@xxxxxx>, kernel-team <Kernel-team@xxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Mon, 25 Aug 2014 11:11:38 +0300 (EEST)
        Hello,

On Mon, 25 Aug 2014, Simon Horman wrote:

> On Mon, Aug 25, 2014 at 08:13:14AM +0300, Julian Anastasov wrote:
> > 
> >     Hello,
> > 
> > On Mon, 25 Aug 2014, Simon Horman wrote:
> > 
> > > On Fri, Aug 01, 2014 at 10:36:17AM +0300, Julian Anastasov wrote:
> > > > The tunneling method should properly use tunnel encapsulation.
> > > > Fixes problem with CHECKSUM_PARTIAL packets when TCP/UDP csum
> > > > offload is supported.
> > > > 
> > > > Thanks to Alex Gartrell for reporting the problem, providing
> > > > solution and for all suggestions.
> > > 
> > > With this patch is Alex's patch "[PATCH ipvs] ipvs: invoke
> > > skb_checksum_help prior to encapsulation in tunnel xmit " also needed?
> > 
> >     Not needed, we prefer to avoid csum calculation by CPU.
> 
> Thanks, understood.
> 
> I have applied (only) this patch to ipvs-next.

        May be we should apply it as bugfix to ipvs tree.
Later stable kernels may need it. Also, new changes from
Alex Gartrell about tunneling depend on it, they are
net-next material, still in development, so I guess this
patch will appear soon on net-next via next -rc if
applied now as bugfix.

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>