Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+ipvs\:\s+fix\s+ipv6\s+icmp\s+forwarding\s+in\s+natted\s+services\s*$/: 24 ]

Total 24 documents matching your query.

1. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Julian Anastasov <ja@xxxxxx>
Date: Fri, 21 Feb 2014 11:34:42 +0200 (EET)
Hello, I don't see any difference what we use here because we used -1 in ip_vs_fill_iph_skb. If not validated once, with -1 we can get a NEXTHDR_NONE result when ipv6_find_hdr returns without error.
/html/lvs-devel/2014-02/msg00038.html (12,522 bytes)

2. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Date: Fri, 21 Feb 2014 06:46:41 +0100
Hello I'll do that. We will save some cycles here, very few actually.. I'm not sure about the mobility header if it can break this. Have not read the RFC :-) The -1 is OK for me right now Regards Han
/html/lvs-devel/2014-02/msg00037.html (15,207 bytes)

3. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Julian Anastasov <ja@xxxxxx>
Date: Fri, 21 Feb 2014 00:17:49 +0200 (EET)
Hello, Thanks for the confirmation. Then may be Hans can post a fix for this problem after checking the callers of ipv6_find_hdr. Yes, it is not expected, the protocol was already validated. May be w
/html/lvs-devel/2014-02/msg00036.html (14,377 bytes)

4. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Thu, 20 Feb 2014 19:56:19 +0100
Hi, I ack the working of that change for my specific case: passing pmtud's correctly: Feb 20 18:58:59 c43236 kernel: [ 721.473388] IPVS: Enter: ip_vs_icmp_xmit_v6, net/netfilter/ipvs/ip_vs_xmit.c lin
/html/lvs-devel/2014-02/msg00035.html (13,943 bytes)

5. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Thu, 20 Feb 2014 14:10:44 +0100
Hi, It will be on my next desktop reboot test round :-). I think I will test 2 hours before EOD, that's around 18:00+0100 -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in th
/html/lvs-devel/2014-02/msg00034.html (11,888 bytes)

6. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Date: Thu, 20 Feb 2014 09:56:37 +0100
Can you try Julians patch insted ? mine was not so good :-) i.e. - if (target < 0) + if (target < 0 || found) break; Regards Hans Attachment: smime.p7s Description: S/MIME cryptographic signature
/html/lvs-devel/2014-02/msg00033.html (13,275 bytes)

7. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Thu, 20 Feb 2014 09:51:55 +0100
Hi, Ah, f**k me :-(. I was so caught up in reloading ipvs that I forgot to reload wherever that function is in, but I guess that's static :-(. So tests like that will take me some longer to perform.
/html/lvs-devel/2014-02/msg00032.html (13,158 bytes)

8. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Thu, 20 Feb 2014 09:40:09 +0100
Hi, Yes :-). I figured that after I added debugging to pinpoint it ;-). I always saw that message in the log but I thought that's some new warning about other devices bugs. The message as it is right
/html/lvs-devel/2014-02/msg00031.html (12,321 bytes)

9. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 23:08:43 +0100
Hi Julian As usual I'm to quick to send the mail... It will work for hmark and it looks like it will work for others, with -1 Maybe Patrick have another opinion... Regards Hans Attachment: smime.p7s
/html/lvs-devel/2014-02/msg00030.html (14,095 bytes)

10. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 22:46:49 +0100
Hi Ansis & Patrick I saw that too in openvswitch/actions.c, i.e it will break your patch But if you want to find a specific header ex. NEXTHDR_GRE, that is not in ipv6_ext_hdr() ipv6_find_hdr() will
/html/lvs-devel/2014-02/msg00029.html (14,587 bytes)

11. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Julian Anastasov <ja@xxxxxx>
Date: Wed, 19 Feb 2014 23:34:46 +0200 (EET)
Hello, This is against the goal of the above commit. May be above check should be: if (target < 0 || found) break; We have to check some callers with -1, may be some need check for NEXTHDR_NONE, for
/html/lvs-devel/2014-02/msg00028.html (13,572 bytes)

12. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Julian Anastasov <ja@xxxxxx>
Date: Wed, 19 Feb 2014 22:44:02 +0200 (EET)
Hello, You mean "IPv6 header not found" ? I guess it happens for the second protocol = ipv6_find_hdr(skb, &offs, -1, &fragoffs, NULL); when icmp_offset was 0. Message is from ipv6_find_hdr. Regards -
/html/lvs-devel/2014-02/msg00027.html (10,966 bytes)

13. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Ansis Atteka <aatteka@xxxxxxxxxx>
Date: Wed, 19 Feb 2014 12:32:07 -0800
My changes to this function were necessary for the Open vSwitch set_ipv6() action implementation so that checksums would be correctly recalculated. I introduced IP6_FH_F_SKIP_RH flag that skips all R
/html/lvs-devel/2014-02/msg00026.html (13,359 bytes)

14. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 21:28:38 +0100
Hello This one bothers me, Why does it returns -ENOENT ??? When enter ipv6_find_hdr() the initial nexthdr should be 0x3a ICMPv6 u8 nexthdr = ipv6_hdr(skb)->nexthdr; and target also 0x3a i.e. found is
/html/lvs-devel/2014-02/msg00025.html (17,136 bytes)

15. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 19:21:04 +0100
Hans, I want to keep the patch as is, but change the description: Fix regression introduced in 3.8 with commit 9195bb8e381d81 ("ipv6: improve ipv6_find_hdr() to skip empty routing headers") which bro
/html/lvs-devel/2014-02/msg00024.html (11,584 bytes)

16. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 19:02:32 +0100
Hi, Found it: if ((!ipv6_ext_hdr(nexthdr)) || nexthdr == NEXTHDR_NONE) So, it keeps traversing until no more ext headers are found (i.e. the protocol header), or no headers at all. Then it tests if y
/html/lvs-devel/2014-02/msg00023.html (12,012 bytes)

17. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 18:53:36 +0100
If I look at the ipv6_find_hdr code, it will actually loop until all headers have been visited, because no header will equal -1. Eventually it will stop because there are no next headers anymore. So
/html/lvs-devel/2014-02/msg00022.html (11,503 bytes)

18. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 18:05:05 +0100
Hi Hans, Ah bah, I thought they move every extra header after the payload. I will take a hard look into that one :-). If I patch my kernel: ard@freeze8dev:/mnt/source/kernels/build-hp-ws/l-3.13.3$ di
/html/lvs-devel/2014-02/msg00021.html (15,208 bytes)

19. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 17:04:17 +0100
Hi Ard and Ansis The problem is if icmp6 is not the first header it will not work... i.e. it can be other headers before icmp and if you have -1 you will not always get the icmp header. The patch tha
/html/lvs-devel/2014-02/msg00020.html (14,988 bytes)

20. Re: [PATCH] ipvs: fix ipv6 icmp forwarding in natted services (score: 1)
Author: Art -kwaak- van Breemen <ard@xxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 11:27:52 +0100
Thanks. I was a reading it, but something with impatience and lazy, and worst of all, I still don't know an easy way to blame without cloning the repository :-( <snipped proof of lazy incompetence> ^
/html/lvs-devel/2014-02/msg00018.html (12,381 bytes)


This search system is powered by Namazu