LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 05/26] IPVS: Use new address family specific debugging macros

To: "Julius R. Volz" <juliusv@xxxxxxxxxx>
Subject: Re: [PATCH 05/26] IPVS: Use new address family specific debugging macros.
Cc: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, horms@xxxxxxxxxxxx, davem@xxxxxxxxxxxxx, vbusam@xxxxxxxxxx
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Wed, 11 Jun 2008 19:14:53 +0200
Julius R. Volz wrote:
Change debug output to use address family specific debugging macros where
appropriate.

-               IP_VS_ERR("request control DEL for uncontrolled: "
-                         "%d.%d.%d.%d:%d to %d.%d.%d.%d:%d\n",
-                         NIPQUAD(cp->caddr),ntohs(cp->cport),
-                         NIPQUAD(cp->vaddr),ntohs(cp->vport));
+               IP_VS_ERR_V4(cp->af, "request control DEL for uncontrolled: "
+                            "%d.%d.%d.%d:%d to %d.%d.%d.%d:%d\n",
+                            NIPQUAD(cp->caddr.v4),ntohs(cp->cport),
+                            NIPQUAD(cp->vaddr.v4),ntohs(cp->vport));
+
+               IP_VS_ERR_V6(cp->af, "request control DEL for uncontrolled: "
+                            NIP6_FMT ":%d to " NIP6_FMT ":%d\n",
+                            NIP6(cp->caddr.v6),ntohs(cp->cport),
+                            NIP6(cp->vaddr.v6),ntohs(cp->vport));
+

This would look at lot cleaner if you'd use a debugging macro that
can take both families.

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>