LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 2/2] ipvs: load balance ipv6 connections from a local process

To: Julius Volz <juliusv@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] ipvs: load balance ipv6 connections from a local process
Cc: Simon Horman <horms@xxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, Malcolm Turnbull <malcolm@xxxxxxxxxxxxxxxx>, Siim Põder <siim@xxxxxxxxxxxxxxx>, Vince Busam <vbusam@xxxxxxxxxx>
From: Brian Haley <brian.haley@xxxxxx>
Date: Fri, 05 Sep 2008 11:55:44 -0400
Julius Volz wrote:
-out:
-       __ip_vs_conn_put(cp);
-
-       return verdict;
+       snet.in6 = iph->saddr;

I've always been told to use ipv6_addr_copy() for this. I'm not sure
what the problem with the direct struct assignment is though... would
be nice if someone could explain.

Because an in6_addr is a union of 4 u32's, which won't all be copied in a struct assignment. That's the way I've always understood it.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>