Re: [PATCH] ldirectord: Allow sending email via external SMTP server

To: Caleb Anthony <caleb.anthony@xxxxxxxxx>
Subject: Re: [PATCH] ldirectord: Allow sending email via external SMTP server
Cc: lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Sat, 9 May 2009 12:05:01 +1000
On Sat, May 09, 2009 at 01:26:57AM +1000, Simon Horman wrote:
> On Fri, May 08, 2009 at 07:38:34AM -0600, Caleb Anthony wrote:
> > It's fairly well tested. I tried to break it as much as I could -
> > setting an unreachable SMTP server, setting an invalid SMTP server
> > address, sending a ton of e-mails with the code by starting, stopping,
> > adding and removing real servers, etc. I'm going to put it into
> > production on a few IPVS directors I have here. I can report back in
> > about a week if you would like.
> > 
> > Also, there needs to be one addition to the ld_emailalert_net_smtp
> > sub. The ld_emailalert_mail_send sub logs a message in ldirectord.log
> > once an email is sent: &ld_log("emailalert: $subject");. I meant to
> > include that same line in ld_emailalert_net_smtp so that each sub
> > would be as similar as possible.
> > 
> > Could you add that line to ld_emailalert_net_smtp before you commit?

I have moved the &ld_log() call to the parent function applied the change.

If any further changes/fixes are needed please make them
as an additional patch.


To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>