LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] IPVS: Removed unused conntrack sysctl entry

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [PATCH] IPVS: Removed unused conntrack sysctl entry
Cc: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Sun, 25 Sep 2011 11:29:12 +0300 (EEST)
        Hello,

On Sun, 25 Sep 2011, Simon Horman wrote:

> This does not appear to be used anywhere.
> 
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> ---
>  net/netfilter/ipvs/ip_vs_ctl.c |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> Julian, I cant see any users of this sysctl in the current code.
> Am I missing something?

        It is used, see ip_vs_conntrack_enabled() in
include/net/ip_vs.h, after the netns changes the var is
named sysctl_conntrack.

> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 36f4495..49befca 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -1605,14 +1605,6 @@ static struct ctl_table vs_vars[] = {
>               .mode           = 0644,
>               .proc_handler   = proc_do_defense_mode,
>       },
> -#ifdef CONFIG_IP_VS_NFCT
> -     {
> -             .procname       = "conntrack",
> -             .maxlen         = sizeof(int),
> -             .mode           = 0644,
> -             .proc_handler   = &proc_dointvec,
> -     },
> -#endif
>       {
>               .procname       = "secure_tcp",
>               .maxlen         = sizeof(int),
> @@ -3535,9 +3527,6 @@ int __net_init __ip_vs_control_init_sysctl(struct net 
> *net)
>       tbl[idx++].data = &ipvs->sysctl_am_droprate;
>       tbl[idx++].data = &ipvs->sysctl_drop_entry;
>       tbl[idx++].data = &ipvs->sysctl_drop_packet;
> -#ifdef CONFIG_IP_VS_NFCT
> -     tbl[idx++].data = &ipvs->sysctl_conntrack;
> -#endif
>       tbl[idx++].data = &ipvs->sysctl_secure_tcp;
>       ipvs->sysctl_snat_reroute = 1;
>       tbl[idx++].data = &ipvs->sysctl_snat_reroute;
> -- 
> 1.7.5.4

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>