LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net-next 1/6] ipvs: properly dereference dest_dst in ip_vs_fo

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net-next 1/6] ipvs: properly dereference dest_dst in ip_vs_forget_dev
Cc: lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 18 Apr 2013 20:45:32 +0900
On Wed, Apr 17, 2013 at 11:50:45PM +0300, Julian Anastasov wrote:
>       Use rcu_dereference_protected to resolve
> sparse warning, found by kbuild test robot:
> 
> net/netfilter/ipvs/ip_vs_ctl.c:1464:35: warning: dereference of
> noderef expression
> 
>       Problem from commit 026ace060dfe29
> ("ipvs: optimize dst usage for real server")

Thanks, this looks reasonable to me.
I have queued it up in ipvs-next.

BTW, Pablo asked previously for patches not to have
leading spaces at the beginning of paragraph's in the changelog.
I can will fix this, but it would be helpful to me if you
could update your chagelog style.

Thanks

> 
> Signed-off-by: Julian Anastasov <ja@xxxxxx>
> ---
>  net/netfilter/ipvs/ip_vs_ctl.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 9e4074c..5a65444 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -1460,8 +1460,11 @@ void ip_vs_service_net_cleanup(struct net *net)
>  static inline void
>  ip_vs_forget_dev(struct ip_vs_dest *dest, struct net_device *dev)
>  {
> +     struct ip_vs_dest_dst *dest_dst;
> +
>       spin_lock_bh(&dest->dst_lock);
> -     if (dest->dest_dst && dest->dest_dst->dst_cache->dev == dev) {
> +     dest_dst = rcu_dereference_protected(dest->dest_dst, 1);
> +     if (dest_dst && dest_dst->dst_cache->dev == dev) {
>               IP_VS_DBG_BUF(3, "Reset dev:%s dest %s:%u ,dest->refcnt=%d\n",
>                             dev->name,
>                             IP_VS_DBG_ADDR(dest->af, &dest->addr),
> -- 
> 1.7.3.4
> 
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>