LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: ipvs: Pull out crosses_local_route_boundary logic

To: Alex Gartrell <agartrell@xxxxxx>
Subject: Re: ipvs: Pull out crosses_local_route_boundary logic
Cc: Julian Anastasov <ja@xxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 6 Oct 2014 16:32:32 +0900
On Sun, Oct 05, 2014 at 04:47:02PM -0700, Alex Gartrell wrote:
> Hey everyone,
> 
> On 10/1/14 12:37 PM, Julian Anastasov wrote:
> >>    312                             *ret_saddr = saddr;
> >>    313             }
> >>    314     
> >>    315             local = (rt->rt_flags & RTCF_LOCAL) ? 1 : 0;
> >>    316             if (unlikely(crosses_local_route_boundary(skb_af, skb, 
> >> rt_mode,
> >>    317                                                       local))) {
> >>    318                     IP_VS_DBG_RL("We are crossing local and 
> >> non-local addresses"
> >>    319                                  " daddr=%pI4\n", &dest->addr.ip);
> >>                                                        ^^^^^^^^^^^^^
> >
> >     Good catch. In fact, I requested Alex to print
> >daddr in this case but then we both missed this dest here...
> >Alex, both v4 (&daddr) and v6 (daddr) should be fixed.
> 
> It doesn't appear to me that there's been a patch for this yet.  I'll write
> one and send it out right away.  Please LMK if there's anyone else I should
> send it to.

I am following this thread so its not a big deal but in general please CC
me as well as Julian and lvs-devel on any patches you want considered for
inclusion in IPVS kernel code.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>