LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] netfilter: ipvs: Fix invalid bytes in IP_VS_MH_TAB_INDEX hel

To: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] netfilter: ipvs: Fix invalid bytes in IP_VS_MH_TAB_INDEX help text
Cc: netfilter-devel@xxxxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Mon, 9 Jul 2018 23:11:07 +0300 (EEST)
        Hello,

On Mon, 2 Jul 2018, Ben Hutchings wrote:

> The help text contains several \xa0 bytes, which are not valid UTF-8
> characters but could have been non-breaking spaces in Latin 1
> encoding.  I see no reason to use non-breaking spaces here, so replace
> them with regular spaces.
> 
> Fixes: 30edf801d7ed ("netfilter: ipvs: Add configurations of Maglev hashing")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

        Looks good to me, thanks!

Acked-by: Julian Anastasov <ja@xxxxxx>

        Pablo, I think you can take it directly, thanks!

> ---
> I've also attached the patch because I'm not totally convinced that
> the \xa0 bytes in the body are going to get through correctly.
> 
> Ben.
> 
>  net/netfilter/ipvs/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig
> index 05dc1b77e466..17b53eee05a5 100644
> --- a/net/netfilter/ipvs/Kconfig
> +++ b/net/netfilter/ipvs/Kconfig
> @@ -296,10 +296,10 @@ config IP_VS_MH_TAB_INDEX
>         stored in a hash table. This table is assigned by a preference
>         list of the positions to each destination until all slots in
>         the table are filled. The index determines the prime for size of
> -       the table as?251, 509, 1021, 2039, 4093, 8191, 16381, 32749,
> -       65521 or 131071.?When using weights to allow destinations to
> -       receive more connections,?the table is assigned an amount
> -       proportional to the weights specified.?The table needs to be large
> +       the table as 251, 509, 1021, 2039, 4093, 8191, 16381, 32749,
> +       65521 or 131071. When using weights to allow destinations to
> +       receive more connections, the table is assigned an amount
> +       proportional to the weights specified. The table needs to be large
>         enough to effectively fit all the destinations multiplied by their
>         respective weights.
>  

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] netfilter: ipvs: Fix invalid bytes in IP_VS_MH_TAB_INDEX help text, Julian Anastasov <=