Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8
Cc: Joe Perches <joe@xxxxxxxxxxx>, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, linux-wireless <linux-wireless@xxxxxxxxxxxxxxx>, Networking <netdev@xxxxxxxxxxxxxxx>, DTML <devicetree@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" <linux-crypto@xxxxxxxxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx, Linux PM list <linux-pm@xxxxxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Wed, 25 Jul 2018 15:12:11 +0200
                            LLVM byte-codes, uncompressed
On Wed, Jul 25, 2018 at 2:55 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 24 Jul 2018 17:13:20 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
>> On Tue, 2018-07-24 at 14:00 -0700, Andrew Morton wrote:
>> > On Tue, 24 Jul 2018 13:13:25 +0200 Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> > > Almost all files in the kernel are either plain text or UTF-8
>> > > encoded. A couple however are ISO_8859-1, usually just a few
>> > > characters in a C comments, for historic reasons.
>> > > This converts them all to UTF-8 for consistency.
>> []
>> > Will we be getting a checkpatch rule to keep things this way?
>> How would that be done?
> I'm using this, seems to work.
>         if ! file $p | grep -q -P ", ASCII text|, UTF-8 Unicode text"
>         then
>                 echo $p: weird charset
>         fi

There are a couple of files that my version of 'find' incorrectly identified as
something completely different, like:

            SemOne archive data
            Microsoft Document Imaging Format
            PPMN archive data
        Sendmail frozen configuration  - version = "host";
        StuffIt Deluxe Segment (data) : gmentation Offloads in the
Linux Networking Stack
arch/sparc/include/asm/visasm.h:                              SAS 7+
arch/xtensa/kernel/setup.c:                                         ,
init=0x454c, stat=0x090a, dev=0x2009, bas=0x2020
TI-XX Graphing Calculator (FLASH)
                            Minix filesystem, V2 (big endian)
                            LLVM byte-codes, uncompressed

All of the above seem to be valid ASCII or UTF-8 files, so the check
above will lead
to false-positives, but it may be good enough as they are the
exception, and may be
bugs in 'file'.

Not sure if we need to worry about 'file' not being installed.

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>