LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v4] ipvs: allow tunneling with gue encapsulation

To: kbuild test robot <lkp@xxxxxxxxx>
Subject: Re: [PATCH v4] ipvs: allow tunneling with gue encapsulation
Cc: kbuild-all@xxxxxx, jacky.hu@xxxxxxxxxxx, jason.niesz@xxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Jacky Hu <hengqing.hu@xxxxxxxxx>
Date: Mon, 18 Mar 2019 11:22:56 +0800
On Mon, Mar 18, 2019 at 10:10:20AM +0800, kbuild test robot wrote:
> Hi Jacky,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on ipvs-next/master]
> [also build test WARNING on v5.1-rc1 next-20190306]
> [if your patch is applied to the wrong git tree, please drop us a note to 
> help improve the system]
> 
> url:    
> https://github.com/0day-ci/linux/commits/Jacky-Hu/ipvs-allow-tunneling-with-gue-encapsulation/20190318-070156
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git 
> master
> reproduce:
>         # apt-get install sparse
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    net/netfilter/ipvs/ip_vs_ctl.c:835:42: sparse: incorrect type in argument 
> 2 (different base types) @@    expected int [signed] i @@    got restricted 
> __be1int [signed] i @@
>    net/netfilter/ipvs/ip_vs_ctl.c:835:42:    expected int [signed] i
>    net/netfilter/ipvs/ip_vs_ctl.c:835:42:    got restricted __be16 [usertype] 
> tun_port
>    net/netfilter/ipvs/ip_vs_ctl.c:1197:44: sparse: expression using 
> sizeof(void)
> >> net/netfilter/ipvs/ip_vs_ctl.c:3207:37: sparse: incorrect type in argument 
> >> 3 (different base types) @@    expected restricted __be16 [usertype] value 
> >> @@    got e] value @@
>    net/netfilter/ipvs/ip_vs_ctl.c:3207:37:    expected restricted __be16 
> [usertype] value
>    net/netfilter/ipvs/ip_vs_ctl.c:3207:37:    got int
>    net/netfilter/ipvs/ip_vs_ctl.c:1313:27: sparse: dereference of noderef 
> expression
> 
> vim +3207 net/netfilter/ipvs/ip_vs_ctl.c
> 
>   3187        
>   3188        static int ip_vs_genl_fill_dest(struct sk_buff *skb, struct 
> ip_vs_dest *dest)
>   3189        {
>   3190                struct nlattr *nl_dest;
>   3191                struct ip_vs_kstats kstats;
>   3192        
>   3193                nl_dest = nla_nest_start(skb, IPVS_CMD_ATTR_DEST);
>   3194                if (!nl_dest)
>   3195                        return -EMSGSIZE;
>   3196        
>   3197                if (nla_put(skb, IPVS_DEST_ATTR_ADDR, 
> sizeof(dest->addr), &dest->addr) ||
>   3198                    nla_put_be16(skb, IPVS_DEST_ATTR_PORT, dest->port) 
> ||
>   3199                    nla_put_u32(skb, IPVS_DEST_ATTR_FWD_METHOD,
>   3200                                (atomic_read(&dest->conn_flags) &
>   3201                                 IP_VS_CONN_F_FWD_MASK)) ||
>   3202                    nla_put_u32(skb, IPVS_DEST_ATTR_WEIGHT,
>   3203                                atomic_read(&dest->weight)) ||
>   3204                    nla_put_u8(skb, IPVS_DEST_ATTR_TUN_TYPE,
>   3205                               atomic_read(&dest->tun_type)) ||
>   3206                    nla_put_be16(skb, IPVS_DEST_ATTR_TUN_PORT,
> > 3207                                 atomic_read(&dest->tun_port)) ||

    Should I change the type of tun_port from __be16 to u16?
    Looks like kbuild bugs a lot on this.

>   3208                    nla_put_u32(skb, IPVS_DEST_ATTR_U_THRESH, 
> dest->u_threshold) ||
>   3209                    nla_put_u32(skb, IPVS_DEST_ATTR_L_THRESH, 
> dest->l_threshold) ||
>   3210                    nla_put_u32(skb, IPVS_DEST_ATTR_ACTIVE_CONNS,
>   3211                                atomic_read(&dest->activeconns)) ||
>   3212                    nla_put_u32(skb, IPVS_DEST_ATTR_INACT_CONNS,
>   3213                                atomic_read(&dest->inactconns)) ||
>   3214                    nla_put_u32(skb, IPVS_DEST_ATTR_PERSIST_CONNS,
>   3215                                atomic_read(&dest->persistconns)) ||
>   3216                    nla_put_u16(skb, IPVS_DEST_ATTR_ADDR_FAMILY, 
> dest->af))
>   3217                        goto nla_put_failure;
>   3218                ip_vs_copy_stats(&kstats, &dest->stats);
>   3219                if (ip_vs_genl_fill_stats(skb, IPVS_DEST_ATTR_STATS, 
> &kstats))
>   3220                        goto nla_put_failure;
>   3221                if (ip_vs_genl_fill_stats64(skb, 
> IPVS_DEST_ATTR_STATS64, &kstats))
>   3222                        goto nla_put_failure;
>   3223        
>   3224                nla_nest_end(skb, nl_dest);
>   3225        
>   3226                return 0;
>   3227        
>   3228        nla_put_failure:
>   3229                nla_nest_cancel(skb, nl_dest);
>   3230                return -EMSGSIZE;
>   3231        }
>   3232        
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

<Prev in Thread] Current Thread [Next in Thread>