Re: [PATCH] ipvs:clean code for ip_vs_sync.c

[Jakub Kicinski <kuba@xxxxxxxxxx>]

On Wed, 15 Jul 2020 12:18:39 +0000 zhouxudong199 wrote:
> Signed-off-by:zhouxudong199 <zhouxudong8@xxxxxxxxxx>

Thank you for the patch.

Please describe the changes you're making in the commit message, as far
as I can tell you're adding missing spaces?

Please read this: https://kernelnewbies.org/KernelJanitors
and make sure to CC kernel-janitors@xxxxxxxxxxxxxxx

Please add a space after ipvs: in the subject and after Signed-off-by:

If you repost please make sure to mark the patch as v2.

> @@ -1232,7 +1232,7 @@ static void ip_vs_process_message(struct netns_ipvs 
> *ipvs, __u8 *buffer,
>               msg_end = buffer + sizeof(struct ip_vs_sync_mesg);
>               nr_conns = m2->nr_conns;
>  
> -             for (i=0; i<nr_conns; i++) {
> +             for (i=0; i < nr_conns; i++) {

you should probably replace i=0 with i = 0.

>                       union ip_vs_sync_conn *s;
>                       unsigned int size;
>                       int retc;