LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl()
Cc: Julian Anastasov <ja@xxxxxx>, Peilin Ye <yepeilin.cs@xxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, Cong Wang <xiyou.wangcong@xxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx, syzkaller-bugs@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Thu, 13 Aug 2020 03:28:35 +0200
On Tue, Aug 11, 2020 at 02:59:59PM +0200, Simon Horman wrote:
> On Tue, Aug 11, 2020 at 01:29:04PM +0300, Julian Anastasov wrote:
> > 
> >     Hello,
> > 
> > On Tue, 11 Aug 2020, Peilin Ye wrote:
> > 
> > > do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is
> > > zero. Fix it.
> > > 
> > > Reported-by: syzbot+23b5f9e7caf61d9a3898@xxxxxxxxxxxxxxxxxxxxxxxxx
> > > Link: 
> > > https://syzkaller.appspot.com/bug?id=46ebfb92a8a812621a001ef04d90dfa459520fe2
> > > Suggested-by: Julian Anastasov <ja@xxxxxx>
> > > Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>
> > 
> >     Looks good to me, thanks!
> > 
> > Acked-by: Julian Anastasov <ja@xxxxxx>
> 
> Pablo, could you consider this for nf-next or should we repost when
> net-next re-opens?

No worries, it will sit in netfilter's patchwork until net-next
reopens.

<Prev in Thread] Current Thread [Next in Thread>