Re: [PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_i

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_init
Cc: Simon Horman <horms@xxxxxxxxxxxx>, <pablo@xxxxxxxxxxxxx>, <christian@xxxxxxxxxx>, <lvs-devel@xxxxxxxxxxxxxxx>, <netfilter-devel@xxxxxxxxxxxxxxx>
From: "wanghai (M)" <wanghai38@xxxxxxxxxx>
Date: Mon, 23 Nov 2020 22:49:10 +0800

在 2020/11/22 19:20, Julian Anastasov 写道:

On Fri, 20 Nov 2020, Wang Hai wrote:

kmemleak report a memory leak as follows:

BUG: memory leak
unreferenced object 0xffff8880759ea000 (size 256):
comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s)

Fixes: b17fc9963f83 ("IPVS: netns, ip_vs_stats and its procfs")
Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Wang Hai <wanghai38@xxxxxxxxxx>
- proc_create_net("ip_vs", 0, ipvs->net->proc_net, &ip_vs_info_seq_ops,
-                       sizeof(struct ip_vs_iter));
-       proc_create_net_single("ip_vs_stats", 0, ipvs->net->proc_net,
-                       ip_vs_stats_show, NULL);
-       proc_create_net_single("ip_vs_stats_percpu", 0, ipvs->net->proc_net,
-                       ip_vs_stats_percpu_show, NULL);
+       if (!proc_create_net("ip_vs", 0, ipvs->net->proc_net, 
+                       sizeof(struct ip_vs_iter)))
+               goto err_vs;
+       if (!proc_create_net_single("ip_vs_stats", 0, ipvs->net->proc_net,
+                       ip_vs_stats_show, NULL))
+               goto err_stats;
+       if (!proc_create_net_single("ip_vs_stats_percpu", 0, 
+                       ip_vs_stats_percpu_show, NULL))
+               goto err_percpu;
        Make sure the parameters are properly aligned to function open
parenthesis without exceeding 80 columns:

linux# scripts/ --strict /tmp/file.patch
Thanks, I'll perfect it.
        It was true only for first call due to some
renames for the others two in commit 3617d9496cd9 :(
It does indeed rename in commit 3617d9496cd9.
But I don't understand what's wrong with my patch here.
if (ip_vs_control_net_init_sysctl(ipvs))
                goto err;
@@ -4180,6 +4185,14 @@ int __net_init ip_vs_control_net_init(struct netns_ipvs 
        return 0;
+       remove_proc_entry("ip_vs_stats_percpu", ipvs->net->proc_net);
        It should look better with an empty line before
the 3 new labels.
Thanks, I'll perfect it.
        remove_proc_entry("ip_vs_stats", ipvs->net->proc_net);
        remove_proc_entry("ip_vs", ipvs->net->proc_net);

Julian Anastasov <ja@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>