LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] Invalidate expired persistance templates

To: "LinuxVirtualServer.org users mailing list." <lvs-users@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Invalidate expired persistance templates
Cc: ja@xxxxxx
Cc: Horms <horms@xxxxxxxxxxxx>
From: Roberto Nibali <ratz@xxxxxxxxxxxx>
Date: Fri, 11 Nov 2005 08:55:44 +0100
Hello guys,

2.4 still sets cp->timeout = 0; in ip_vs_conn_expire_now, so this
is probably a good fix.

        May be better ip_vs_conn_expire_now() in 2.4 to be converted
to be as in 2.6 because there can be kernel timer patches for 2.4 that

Yes, it should be adjusted to 2.6.x behaviour. I would really love to tidy up the 2.4.x stuff a bit to have it close to 2.6.x in case bugs like this one show up.

allow timer handler for same cp to run on many CPUs. There is no
reason to keep it in this way, especially now when we don't like
cp->timeout to be 0. Then ip_vs_conn_expire() for 2.4 will use
cp->timeout in the same way as 2.6. We must be sure cp->timeout is
not set to 0 for some reason, by checking code in 2.4 and 2.6.

What about resetting the timer to (tcp timeout - persistency template timeout)?

Regards,
Roberto Nibali, ratz
--
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc

<Prev in Thread] Current Thread [Next in Thread>