LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [lvs-users] ldirectord checktype external-perl

To: "LinuxVirtualServer.org users mailing list." <lvs-users@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [lvs-users] ldirectord checktype external-perl
Cc: Bright Fulton <bright.fulton@xxxxxxxxx>, Graeme Fowler <graeme@xxxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 16 Jan 2009 14:15:21 +1100
On Wed, Jan 14, 2009 at 06:27:05PM -0500, Bright Fulton wrote:
> On Tue, Jan 13, 2009 at 5:42 PM, Bright Fulton <bright.fulton@xxxxxxxxx> 
> wrote:
> > I'm using the following (and attached, if it gets through) patch to
> > ldirectord which adds a new checktype: external-perl.  This allows an
> > external check which is written in Perl to run as a call to an
> > anonymous subroutine instead of to system().  I'd appreciate any
> > comments on the concept, implementation and possibility of acceptance.
>
> Apologies, the following is also required.  This fixes a bug in the
> introduced exit() wrapping: we need to pass a scalar to CORE::exit or
> ldirectord will always exit 1.
> 
> diff -r --exclude=.hg heartbeat-dev/ldirectord/ldirectord.in
> heartbeat-dev-2/ldirectord/ldirectord.in
> 729c729
> <       *CORE::GLOBAL::exit = sub { CORE::exit @_; }
> ---
> >       *CORE::GLOBAL::exit = sub { CORE::exit(@_ ? shift : 0); };
> 
> The cumulative patch is attached.

Thanks, I have applied this to the linux-ha dev tree, and it should appear
in the next release.

http://hg.linux-ha.org/dev/rev/f2ec804aa6b7

If you have any updates please send them to lvs-users or lvs-devel
and CC me.

Thanks

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@xxxxxxxxxxxxxxxxxxxxxx
Send requests to lvs-users-request@xxxxxxxxxxxxxxxxxxxxxx
or go to http://lists.graemef.net/mailman/listinfo/lvs-users

<Prev in Thread] Current Thread [Next in Thread>