LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [lvs-users] [PATCH] IPVS: logging sizeof(struct ip_vs_conn) on start

To: Hannes Eder <heder@xxxxxxxxxx>
Subject: Re: [lvs-users] [PATCH] IPVS: logging sizeof(struct ip_vs_conn) on startup
Cc: lvs-users@xxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, malcolm@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Mon, 27 Jul 2009 11:25:25 +0200
Hannes Eder a écrit :
> No more guessing, how much memory is used by IPVS for a connection.
> 
> Signed-off-by: Hannes Eder <heder@xxxxxxxxxx>
> ---
>  net/netfilter/ipvs/ip_vs_core.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
> index b021464..5b0997c 100644
> --- a/net/netfilter/ipvs/ip_vs_core.c
> +++ b/net/netfilter/ipvs/ip_vs_core.c
> @@ -1475,7 +1475,8 @@ static int __init ip_vs_init(void)
>               goto cleanup_conn;
>       }
>  
> -     IP_VS_INFO("ipvs loaded.\n");
> +     IP_VS_INFO("ipvs loaded (using %Zd bytes/connection).\n",
> +            sizeof(struct ip_vs_conn));
>       return ret;
>  
>    cleanup_conn:

Well, ip_vs_conn_cache uses SLAB_HWCACHE_ALIGN, so this should be rounded up
to L1 cache size. Or add "at least" like in line 1080
of net/netfilter/ipvs/ip_vs_conn.c :

        IP_VS_DBG(0, "Each connection entry needs %Zd bytes at least\n",
                  sizeof(struct ip_vs_conn));


_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@xxxxxxxxxxxxxxxxxxxxxx
Send requests to lvs-users-request@xxxxxxxxxxxxxxxxxxxxxx
or go to http://lists.graemef.net/mailman/listinfo/lvs-users
<Prev in Thread] Current Thread [Next in Thread>