LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [lvs-users] "connection refused" when persistence enabled

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [lvs-users] "connection refused" when persistence enabled
Cc: lvs-users@xxxxxxxxxxxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Fri, 11 Dec 2009 11:01:47 +0200 (EET)
        Hello,

On Fri, 11 Dec 2009, Simon Horman wrote:

> Hi Julian,
> 
> I took a look at your suggestion and zeroing usvc in
> ip_vs_genl_parse_service() also seems to does seem to resolve the problem
> that was reported. And inspecting the code it looks like it should
> be sufficient to resolve any similar problems that may be lurking.
> 
> How do you feel about the following?

        Looks good. May be you can do the same for ip_vs_genl_parse_dest,
just to be safe, if new parameter is added but netlink does not support 
it, we do not want random data from stack.

> ----------------------------------------------------------------------
> 
> ipvs: zero usvc
> 
> Make sure that any otherwise uninitialised fields of usvc are zero.
> 
> This has been obvserved to cause a problem whereby the port of
> fwmark services may end up as a non-zero value which causes
> scheduling of a destination server to fail for persisitent services.
> 
> As observed by Deon van der Merwe <dvdm@xxxxxxxxxxxx>.
> This fix suggested by Julian Anastasov <ja@xxxxxx>.
> 
> Cc: Deon van der Merwe <dvdm@xxxxxxxxxxxx>
> Cc: Julian Anastasov <ja@xxxxxx>
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>


Acked-by: Julian Anastasov <ja@xxxxxx>


> Index: linux-2.6/net/netfilter/ipvs/ip_vs_ctl.c
> ===================================================================
> --- linux-2.6.orig/net/netfilter/ipvs/ip_vs_ctl.c     2009-12-11 
> 14:22:23.000000000 +0900
> +++ linux-2.6/net/netfilter/ipvs/ip_vs_ctl.c  2009-12-11 14:25:03.000000000 
> +0900
> @@ -2714,6 +2714,8 @@ static int ip_vs_genl_parse_service(stru
>       if (!(nla_af && (nla_fwmark || (nla_port && nla_protocol && nla_addr))))
>               return -EINVAL;
>  
> +     memset(usvc, 0, sizeof(*usvc));
> +
>       usvc->af = nla_get_u16(nla_af);
>  #ifdef CONFIG_IP_VS_IPV6
>       if (usvc->af != AF_INET && usvc->af != AF_INET6)

Regards

--
Julian Anastasov <ja@xxxxxx>

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@xxxxxxxxxxxxxxxxxxxxxx
Send requests to lvs-users-request@xxxxxxxxxxxxxxxxxxxxxx
or go to http://lists.graemef.net/mailman/listinfo/lvs-users

<Prev in Thread] Current Thread [Next in Thread>