LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net-next] ipvs: use 64-bit rates in stats

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net-next] ipvs: use 64-bit rates in stats
Cc: lvs-devel@xxxxxxxxxxxxxxx, lvs-users@xxxxxxxxxxxxxxxxxxxxxx, Chris Caputo <ccaputo@xxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 9 Feb 2015 17:01:20 +0900
On Mon, Feb 09, 2015 at 08:41:32AM +0200, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Mon, 9 Feb 2015, Simon Horman wrote:
> 
> > On Fri, Feb 06, 2015 at 09:44:44AM +0200, Julian Anastasov wrote:
> > > IPVS stats are limited to 2^(32-10) conns/s and packets/s,
> > > 2^(32-5) bytes/s. It is time to use 64 bits:
> > > 
> > > * Change all conn/packet kernel counters to 64-bit and update
> > > them in u64_stats_update_{begin,end} section
> > > 
> > > * In kernel use struct ip_vs_kstats instead of the user-space
> > > struct ip_vs_stats_user and use new func ip_vs_export_stats_user
> > > to export it to sockopt users to preserve compatibility with
> > > 32-bit values
> > > 
> > > * Rename cpu counters "ustats" to "cnt"
> > > 
> > > * To netlink users provide additionally 64-bit stats:
> > > IPVS_SVC_ATTR_STATS64 and IPVS_DEST_ATTR_STATS64. Old stats
> > > remain for old binaries.
> > > 
> > > * We can use ip_vs_copy_stats in ip_vs_stats_percpu_show
> > > 
> > > Thanks to Chris Caputo for providing initial patch for ip_vs_est.c
> > > 
> > > Signed-off-by: Chris Caputo <ccaputo@xxxxxxx>
> > > Signed-off-by: Julian Anastasov <ja@xxxxxx>
> > > ---
> > > 
> > > Nothing is changed from previous RFC version.
> > 
> > Hi Julian,
> > 
> > I'm happy to take this. Can you confirm that you are ready for me to do so?
> 
>       Yep, please apply.

Thanks, I have applied it to ipvs-next.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>