![]()  | 
 
lvs-devel
 
 | 
| To: | Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> | 
|---|---|
| Subject: | [PATCH 16/18] IPVS: ip_vs_ftp.c: local functions should not be exposed globally | 
| Cc: | lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>, Jesper Dangaard Brouer <brouer@xxxxxxxxxx>, H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx>, H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx> | 
| From: | Simon Horman <horms@xxxxxxxxxxxx> | 
| Date: | Wed, 2 May 2012 15:22:40 +0900 | 
From: H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx>
Functions not referenced outside of a source file should be marked
static to prevent it from being exposed globally.
This quiets the sparse warnings:
warning: symbol 'ip_vs_ftp_init' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
 net/netfilter/ipvs/ip_vs_ftp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
index debb8c7..091bec9 100644
--- a/net/netfilter/ipvs/ip_vs_ftp.c
+++ b/net/netfilter/ipvs/ip_vs_ftp.c
@@ -483,7 +483,7 @@ static struct pernet_operations ip_vs_ftp_ops = {
        .exit = __ip_vs_ftp_exit,
 };
 
-int __init ip_vs_ftp_init(void)
+static int __init ip_vs_ftp_init(void)
 {
        int rv;
 
-- 
1.7.10
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
 | 
| Previous by Date: | [PATCH 14/18] ipvs: add support for sync threads, Simon Horman | 
|---|---|
| Next by Date: | [PATCH 15/18] ipvs: optimize the use of flags in ip_vs_bind_dest, Simon Horman | 
| Previous by Thread: | [PATCH 14/18] ipvs: add support for sync threads, Simon Horman | 
| Next by Thread: | [PATCH 15/18] ipvs: optimize the use of flags in ip_vs_bind_dest, Simon Horman | 
| Indexes: | [Date] [Thread] [Top] [All Lists] |