Re: [PATCH net] ipvs: avoid netns exit crash on ip_vs_conn_drop_conntrack

[Hans Schillstrom <hans@xxxxxxxxxxxxxxx>]

Hi Julian


On Thu, 2014-07-10 at 09:24 +0300, Julian Anastasov wrote: 
> commit 8f4e0a18682d91 ("IPVS netns exit causes crash in conntrack")
> added second ip_vs_conn_drop_conntrack call instead of just adding
> the needed check. As result, the first call still can cause
> crash on netns exit. Remove it.
> 

Oops must have forgot to take that row away


> Signed-off-by: Julian Anastasov <ja@xxxxxx>

Signed-off-by: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>

> ---
>  net/netfilter/ipvs/ip_vs_conn.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index a8eb0a8..610e19c 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -797,7 +797,6 @@ static void ip_vs_conn_expire(unsigned long data)
>                       ip_vs_control_del(cp);
>  
>               if (cp->flags & IP_VS_CONN_F_NFCT) {
> -                     ip_vs_conn_drop_conntrack(cp);
>                       /* Do not access conntracks during subsys cleanup
>                        * because nf_conntrack_find_get can not be used after
>                        * conntrack cleanup for the net.

smime.p7s
Description: S/MIME cryptographic signature