lvs-devel
|
To: | Wensong Zhang <wensong@xxxxxxxxxxxx> |
---|---|
Subject: | [patch] ipvs: freeing uninitialized pointer on error |
Cc: | Simon Horman <horms@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, netfilter@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx |
From: | Dan Carpenter <dan.carpenter@xxxxxxxxxx> |
Date: | Fri, 25 Jan 2013 18:44:57 +0300 |
If state != IP_VS_STATE_BACKUP then tinfo->buf is uninitialized. If kthread_run() fails then it means we free random memory resulting in an oops. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c index effa10c..44fd10c 100644 --- a/net/netfilter/ipvs/ip_vs_sync.c +++ b/net/netfilter/ipvs/ip_vs_sync.c @@ -1795,6 +1795,8 @@ int start_sync_thread(struct net *net, int state, char *mcast_ifn, __u8 syncid) GFP_KERNEL); if (!tinfo->buf) goto outtinfo; + } else { + tinfo->buf = NULL; } tinfo->id = id; -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html |
<Prev in Thread] | Current Thread | [Next in Thread> |
---|---|---|
|
Next by Date: | Re: [patch] ipvs: freeing uninitialized pointer on error, Julian Anastasov |
---|---|
Next by Thread: | Re: [patch] ipvs: freeing uninitialized pointer on error, Julian Anastasov |
Indexes: | [Date] [Thread] [Top] [All Lists] |