Re: [PATCH ipvs-next] ipvs: Remove rcu_read_unlock();rcu_read_lock();

[Simon Horman <horms@xxxxxxxxxxxx>]

On Thu, Apr 25, 2013 at 10:46:55PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Thu, 25 Apr 2013, Eric Dumazet wrote:
> 
> > On Thu, 2013-04-25 at 22:36 +0900, Simon Horman wrote:
> > 
> > > Ok, leaving it seems reasonable.
> > > Pablo, do you have any objections?
> > 
> > I have objections.
> > 
> > I would _add_ a cond_resched() there to explicitly do what we want
> > 
> > Maybe a macro/inline doing this already exists.
> > 
> > static void inline cond_resched_rcu_lock(void)
> > {
> >     if (need_resched()) {
> >             rcu_read_unlock();
> >             cond_resched();
> >             rcu_read_lock();
> >     }
> > }
> 
>       Thanks, looks like a good idea to me, I guess
> its place is include/linux/sched.h. Simon, can you prepare
> 2 patches instead, one for cond_resched_rcu_lock and second
> for ipvs?

Sure, will do.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html