Re: [PATCH net 1/3] ipv6: always prefer rt6i_gateway if present

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net 1/3] ipv6: always prefer rt6i_gateway if present
Cc: David Miller <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
From: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 21 Oct 2013 07:00:36 +0200
On Sun, Oct 20, 2013 at 03:43:03PM +0300, Julian Anastasov wrote:
> In v3.9 6fd6ce2056de2709 ("ipv6: Do not depend on rt->n in
> ip6_finish_output2()." changed the behaviour of ip6_finish_output2()
> such that the recently introduced rt6_nexthop() is used
> instead of an assigned neighbor.
> As rt6_nexthop() prefers rt6i_gateway only for gatewayed
> routes this causes a problem for users like IPVS, xt_TEE and
> RAW(hdrincl) if they want to use different address for routing
> compared to the destination address.
> Another case is when redirect can create RTF_DYNAMIC
> route without RTF_GATEWAY flag, we ignore the rt6i_gateway
> in rt6_nexthop().
> Fix the above problems by considering the rt6i_gateway if
> present, so that traffic routed to address on local subnet is
> not wrongly diverted to the destination address.
> Thanks to Simon Horman and Phil Oester for spotting the
> problematic commit.
> Thanks to Hannes Frederic Sowa for his review and help in testing.
> Reported-by: Phil Oester <kernel@xxxxxxxxxxxx>
> Reported-by: Mark Brooks <mark@xxxxxxxxxxxxxxxx>
> Signed-off-by: Julian Anastasov <ja@xxxxxx>

Acked-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>