LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs: fix inability to remove a mixed-family RS

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH] ipvs: fix inability to remove a mixed-family RS
Cc: Alexey Andriyanov <alan@xxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, Alex Gartrell <agartrell@xxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 9 Feb 2015 14:25:26 +0900
On Fri, Feb 06, 2015 at 10:27:52PM +0200, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Fri, 6 Feb 2015, Alexey Andriyanov wrote:
> 
> > The current code prevents any operation with a mixed-family dest
> > unless IP_VS_CONN_F_TUNNEL flag is set. The problem is that it's impossible
> > for the client to follow this rule, because ip_vs_genl_parse_dest does
> > not even read the destination conn_flags when cmd = IPVS_CMD_DEL_DEST
> > (need_full_dest = 0).
> > 
> > Also, not every client can pass this flag when removing a dest. ipvsadm,
> > for example, does not support the "-i" command line option together with
> > the "-d" option.
> > 
> > This change disables any checks for mixed-family on IPVS_CMD_DEL_DEST 
> > command.
> > 
> > Signed-off-by: Alexey Andriyanov <alan@xxxxxxxxxx>
> 
>       Good catch.
> 
> Fixes: bc18d37f676f ("ipvs: Allow heterogeneous pools now that we support 
> them")
> Acked-by: Julian Anastasov <ja@xxxxxx>
> 
>       Simon, please apply this bug fix.

Thanks, done.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>