LVS
lvs-devel
[Top] [All Lists]
Google
 
Web LinuxVirtualServer.org
<prev [Date] next> <prev [Thread] next>

Re: [PATCH] net-ipvs: Delete an unnecessary check before the function ca

from [Simon Horman] [Permanent Link]
To: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] net-ipvs: Delete an unnecessary check before the function call "module_put"
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>, Julia Lawall <julia.lawall@xxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 9 Jul 2015 10:41:02 +0900 
On Thu, Jul 02, 2015 at 05:10:41PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 2 Jul 2015 17:00:14 +0200
> 
> The module_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.

Thanks, applied to ipvs-next for v4.3.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH net] ipvs: fix crash with sync protocol v0 and FTP, Simon Horman
Next by Date:  [PATCH ipvs] ipvs: call skb_sender_cpu_clear, Julian Anastasov
Previous by Thread:  [PATCH] net-ipvs: Delete an unnecessary check before the function call "module_put", SF Markus Elfring
Next by Thread:  [PATCH net-next] ipvs: skb_orphan in case of forwarding, Alex Gartrell
Indexes:  [Date] [Thread] [Top] [All Lists]