Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the fun

lvs-devel

Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the fun

To:	Simon Horman <horms@xxxxxxxxxxxx>
Subject:	Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put"
Cc:	lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
From:	Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date:	Wed, 15 Jul 2015 19:00:00 +0200

On Fri, Jul 10, 2015 at 03:42:49PM +0900, Simon Horman wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> 
> The module_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Applied, thanks Simon.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[GIT PULL nf-next] IPVS for v4.3, Simon Horman [PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put", Simon Horman Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put", Pablo Neira Ayuso <=

Previous by Date:	Re: [PATCH net-next] ipvs: fix ipv6 route unreach panic, Simon Horman
Next by Date:	[PATCH nf 1/6] ipvs: fix ipv6 route unreach panic, Simon Horman
Previous by Thread:	[PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put", Simon Horman
Next by Thread:	ovf scheduler, rhadoo.io88
Indexes:	[Date] [Thread] [Top] [All Lists]