LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

[PATCH] libipvs: discrepancy with libnl genlmsg_put

To: lvs-devel@xxxxxxxxxxxxxxx
Subject: [PATCH] libipvs: discrepancy with libnl genlmsg_put
Cc: Arthur Gautier <baloo@xxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
From: baloo@xxxxxxxxx
Date: Wed, 27 Sep 2017 15:31:05 +0000
From: Arthur Gautier <baloo@xxxxxxxxx>

There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
first should be used with genlmsg_put while the second with
nlmsg_put.

This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
have the same value, but still a discrepancy with libnl documentation.

see documentation of genlmsg_put here:
  
http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946

Cc: Julian Anastasov <ja@xxxxxx>
Cc: Simon Horman <horms@xxxxxxxxxxxx>
Cc: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
Signed-off-by: Arthur Gautier <baloo@xxxxxxxxx>
---
 libipvs/libipvs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libipvs/libipvs.c b/libipvs/libipvs.c
index d271c48e36faa..a8432431fbbf6 100644
--- a/libipvs/libipvs.c
+++ b/libipvs/libipvs.c
@@ -63,7 +63,7 @@ struct nl_msg *ipvs_nl_message(int cmd, int flags)
        if (!msg)
                return NULL;
 
-       genlmsg_put(msg, NL_AUTO_PID, NL_AUTO_SEQ, family, 0, flags,
+       genlmsg_put(msg, NL_AUTO_PORT, NL_AUTO_SEQ, family, 0, flags,
                    cmd, IPVS_GENL_VERSION);
 
        return msg;
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] libipvs: discrepancy with libnl genlmsg_put, baloo <=