LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net-next 3/3] ipvs: strip udp tunnel headers from icmp errors

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net-next 3/3] ipvs: strip udp tunnel headers from icmp errors
Cc: lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Jacky Hu <hengqing.hu@xxxxxxxxx>, jacky.hu@xxxxxxxxxxx, jason.niesz@xxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Sat, 4 May 2019 11:15:02 +0200
On Wed, May 01, 2019 at 05:07:16PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Wed, 1 May 2019, Simon Horman wrote:
> 
> > > > > >     We can easily add simple FOU in ipvs_udp_decap() by
> > > > > > returning 0 and correct *proto. Or you prefer to use common
> > > > > > code from other files to parse the headers? Currently, there
> > > > > > is no any GUE func that can be used for this.
> > > > > 
> > > > > My feeling is that using common code, even new common code, would
> > > > > be better.
> > > > 
> > > >         Let me know If you prefer to add GUE code that we can use
> > > > in this patchset, I can test it easily. I'll delay with v2 to
> > > > incorporate any needed changes.
> > > 
> > > Thanks Julian,
> > > 
> > > yes, I would prefer that.
> > 
> > Thanks again Julian,
> > 
> > is a v2 of this series pending or am I mistaken somehow?
> 
>       I thought you will have some separate patch that adds
> code to be used in v2 but if you prefer I can release v2, so
> that you can add followup patch[es] based on that.

Thanks, I think sending v2 would be best.

<Prev in Thread] Current Thread [Next in Thread>