LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCHv2 net-next 0/3] Add UDP tunnel support for ICMP errors in IPV

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCHv2 net-next 0/3] Add UDP tunnel support for ICMP errors in IPVS
Cc: lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Jacky Hu <hengqing.hu@xxxxxxxxx>, jacky.hu@xxxxxxxxxxx, jason.niesz@xxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 7 May 2019 15:47:45 +0200
On Sun, May 05, 2019 at 03:14:37PM +0300, Julian Anastasov wrote:
> This patchset is a followup to the commit that adds UDP/GUE tunnel:
> "ipvs: allow tunneling with gue encapsulation".
> 
> What we do is to put tunnel real servers in hash table (patch 1),
> add function to lookup tunnels (patch 2) and use it to strip the
> embedded tunnel headers from ICMP errors (patch 3).
> 
> v1->v2:
> patch 1: remove extra parentheses
> patch 2: remove extra parentheses
> patch 3: parse UDP header into ipvs_udp_decap
> patch 3: v1 ignores forwarded ICMP errors for UDP, do not do that
> patch 3: add comment for fragment check
> 
> Julian Anastasov (3):
>   ipvs: allow rs_table to contain different real server types
>   ipvs: add function to find tunnels
>   ipvs: strip udp tunnel headers from icmp errors

Thanks Julian,

this looks good for me.
For all patches:

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Pablo, could you consider applying these to nf-next when appropriate?


<Prev in Thread] Current Thread [Next in Thread>