LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl
Cc: hujunwei <hujunwei4@xxxxxxxxxx>, wensong@xxxxxxxxxxxx, horms@xxxxxxxxxxxx, kadlec@xxxxxxxxxxxxxxxxx, Florian Westphal <fw@xxxxxxxxx>, davem@xxxxxxxxxxxxx, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, Mingfangsen <mingfangsen@xxxxxxxxxx>, wangxiaogang3@xxxxxxxxxx, xuhanbing@xxxxxxxxxx
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Sat, 3 Aug 2019 18:40:15 +0200
On Wed, Jul 31, 2019 at 08:53:47PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Thu, 1 Aug 2019, hujunwei wrote:
> 
> > From: Junwei Hu <hujunwei4@xxxxxxxxxx>
> > 
> > The ipvs module parse the user buffer and save it to sysctl,
> > then check if the value is valid. invalid value occurs
> > over a period of time.
> > Here, I add a variable, struct ctl_table tmp, used to read
> > the value from the user buffer, and save only when it is valid.
> > I delete proc_do_sync_mode and use extra1/2 in table for the
> > proc_dointvec_minmax call.
> > 
> > Fixes: f73181c8288f ("ipvs: add support for sync threads")
> > Signed-off-by: Junwei Hu <hujunwei4@xxxxxxxxxx>
> > Acked-by: Julian Anastasov <ja@xxxxxx>
> 
>       Yep, Acked-by: Julian Anastasov <ja@xxxxxx>

Applied, thanks.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl, Pablo Neira Ayuso <=