Re: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr

To:	David Laight <David.Laight@xxxxxxxxxx>
Subject:	Re: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t
Cc:	'Christoph Hellwig' <hch@xxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, "linux-crypto@xxxxxxxxxxxxxxx" <linux-crypto@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "bpf@xxxxxxxxxxxxxxx" <bpf@xxxxxxxxxxxxxxx>, "netfilter-devel@xxxxxxxxxxxxxxx" <netfilter-devel@xxxxxxxxxxxxxxx>, "coreteam@xxxxxxxxxxxxx" <coreteam@xxxxxxxxxxxxx>, "linux-sctp@xxxxxxxxxxxxxxx" <linux-sctp@xxxxxxxxxxxxxxx>, "linux-hams@xxxxxxxxxxxxxxx" <linux-hams@xxxxxxxxxxxxxxx>, "linux-bluetooth@xxxxxxxxxxxxxxx" <linux-bluetooth@xxxxxxxxxxxxxxx>, "bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx" <bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "linux-can@xxxxxxxxxxxxxxx" <linux-can@xxxxxxxxxxxxxxx>, "dccp@xxxxxxxxxxxxxxx" <dccp@xxxxxxxxxxxxxxx>, "linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx" <linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx>, "linux-wpan@xxxxxxxxxxxxxxx" <linux-wpan@xxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "mptcp@xxxxxxxxxxxx" <mptcp@xxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, "rds-devel@xxxxxxxxxxxxxx" <rds-devel@xxxxxxxxxxxxxx>, "linux-afs@xxxxxxxxxxxxxxxxxxx" <linux-afs@xxxxxxxxxxxxxxxxxxx>, "tipc-discussion@xxxxxxxxxxxxxxxxxxxxx" <tipc-discussion@xxxxxxxxxxxxxxxxxxxxx>, "linux-x25@xxxxxxxxxxxxxxx" <linux-x25@xxxxxxxxxxxxxxx>
From:	'Christoph Hellwig' <hch@xxxxxx>
Date:	Thu, 23 Jul 2020 13:44:58 +0200

To:

Subject:

Re: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t

Cc:

'Christoph Hellwig' <hch@xxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, "linux-crypto@xxxxxxxxxxxxxxx" <linux-crypto@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "bpf@xxxxxxxxxxxxxxx" <bpf@xxxxxxxxxxxxxxx>, "netfilter-devel@xxxxxxxxxxxxxxx" <netfilter-devel@xxxxxxxxxxxxxxx>, "coreteam@xxxxxxxxxxxxx" <coreteam@xxxxxxxxxxxxx>, "linux-sctp@xxxxxxxxxxxxxxx" <linux-sctp@xxxxxxxxxxxxxxx>, "linux-hams@xxxxxxxxxxxxxxx" <linux-hams@xxxxxxxxxxxxxxx>, "linux-bluetooth@xxxxxxxxxxxxxxx" <linux-bluetooth@xxxxxxxxxxxxxxx>, "bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx" <bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "linux-can@xxxxxxxxxxxxxxx" <linux-can@xxxxxxxxxxxxxxx>, "dccp@xxxxxxxxxxxxxxx" <dccp@xxxxxxxxxxxxxxx>, "linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx" <linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx>, "linux-wpan@xxxxxxxxxxxxxxx" <linux-wpan@xxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "mptcp@xxxxxxxxxxxx" <mptcp@xxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, "rds-devel@xxxxxxxxxxxxxx" <rds-devel@xxxxxxxxxxxxxx>, "linux-afs@xxxxxxxxxxxxxxxxxxx" <linux-afs@xxxxxxxxxxxxxxxxxxx>, "tipc-discussion@xxxxxxxxxxxxxxxxxxxxx" <tipc-discussion@xxxxxxxxxxxxxxxxxxxxx>, "linux-x25@xxxxxxxxxxxxxxx" <linux-x25@xxxxxxxxxxxxxxx>

From:

'Christoph Hellwig' <hch@xxxxxx>

Date:

Thu, 23 Jul 2020 13:44:58 +0200

On Thu, Jul 23, 2020 at 11:16:16AM +0000, David Laight wrote:
> From: Christoph Hellwig
> > Sent: 23 July 2020 07:09
> > 
> > This is mostly to prepare for cleaning up the callers, as bpfilter by
> > design can't handle kernel pointers.
> 
> You've failed to fix the sense of the above...

The sense still is correct.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 18/26] net/ipv6: split up ipv6_flowlabel_opt, (continued) [PATCH 18/26] net/ipv6: split up ipv6_flowlabel_opt, Christoph Hellwig [PATCH 17/26] net/ipv6: switch ip6_mroute_setsockopt to sockptr_t, Christoph Hellwig [PATCH 23/26] net/tcp: switch ->md5_parse to sockptr_t, Christoph Hellwig [PATCH 22/26] net/udp: switch udp_lib_setsockopt to sockptr_t, Christoph Hellwig [PATCH 16/26] net/ipv4: switch do_ip_setsockopt to sockptr_t, Christoph Hellwig [PATCH 15/26] net/ipv4: merge ip_options_get and ip_options_get_from_user, Christoph Hellwig [PATCH 21/26] net/ipv6: switch do_ipv6_setsockopt to sockptr_t, Christoph Hellwig [PATCH 20/26] net/ipv6: factor out a ipv6_set_opt_hdr helper, Christoph Hellwig [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, Christoph Hellwig RE: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, David Laight Re: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, 'Christoph Hellwig' <= [PATCH 10/26] netfilter: remove the unused user argument to do_update_counters, Christoph Hellwig [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Christoph Hellwig Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Jason A. Donenfeld Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Christoph Hellwig Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Jason A. Donenfeld Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Christoph Hellwig RE: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, David Laight Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Jason A. Donenfeld Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Christoph Hellwig Re: [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t, Jason A. Donenfeld

Previous by Date:	RE: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, David Laight
Next by Date:	RE: [PATCH 03/26] bpfilter: reject kernel addresses, David Laight
Previous by Thread:	RE: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, David Laight
Next by Thread:	[PATCH 10/26] netfilter: remove the unused user argument to do_update_counters, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

RE: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, David Laight

Next by Date:

RE: [PATCH 03/26] bpfilter: reject kernel addresses, David Laight

Previous by Thread:

RE: [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t, David Laight

Next by Thread:

[PATCH 10/26] netfilter: remove the unused user argument to do_update_counters, Christoph Hellwig

Indexes:

[Date] [Thread] [Top] [All Lists]