Re: [PATCH] ipvs: adjust the debug order of src and dst

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote:
> From: ylg <bigclouds@xxxxxxx>
> 
> adjust the debug order of src and dst when tcp state changes
> 
> Signed-off-by: ylg <bigclouds@xxxxxxx>

Hi,

This sounds reasonable to me but please provide your real name
in the Signed-off-by name, which should be consistent with the From field
at the top of the commit message (or, if absent of the email).

Thanks!

> ---
>  net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c 
> b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> index dc2e7da2742a..6567eb45a234 100644
> --- a/net/netfilter/ipvs/ip_vs_proto_tcp.c
> +++ b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> @@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct 
> ip_vs_conn *cp,
>                             th->fin ? 'F' : '.',
>                             th->ack ? 'A' : '.',
>                             th->rst ? 'R' : '.',
> -                           IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> -                           ntohs(cp->dport),
>                             IP_VS_DBG_ADDR(cp->af, &cp->caddr),
>                             ntohs(cp->cport),
> +                           IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> +                           ntohs(cp->dport),
>                             tcp_state_name(cp->state),
>                             tcp_state_name(new_state),
>                             refcount_read(&cp->refcnt));
> -- 
> 2.20.1 (Apple Git-117)
>