LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel eleme

To: Paolo Abeni <pabeni@xxxxxxxxxx>
Subject: Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array
Cc: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>, <devnull+j.granados.samsung.com@xxxxxxxxxx>, <Dai.Ngo@xxxxxxxxxx>, <alex.aring@xxxxxxxxx>, <alibuda@xxxxxxxxxxxxxxxxx>, <allison.henderson@xxxxxxxxxx>, <anna@xxxxxxxxxx>, <bridge@xxxxxxxxxxxxxxx>, <chuck.lever@xxxxxxxxxx>, <coreteam@xxxxxxxxxxxxx>, <courmisch@xxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <dccp@xxxxxxxxxxxxxxx>, <dhowells@xxxxxxxxxx>, <dsahern@xxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <fw@xxxxxxxxx>, <geliang@xxxxxxxxxx>, <guwen@xxxxxxxxxxxxxxxxx>, <herbert@xxxxxxxxxxxxxxxxxxx>, <horms@xxxxxxxxxxxx>, <ja@xxxxxx>, <jaka@xxxxxxxxxxxxx>, <jlayton@xxxxxxxxxx>, <jmaloy@xxxxxxxxxx>, <jreuter@xxxxxxxx>, <kadlec@xxxxxxxxxxxxx>, <keescook@xxxxxxxxxxxx>, <kolga@xxxxxxxxxx>, <kuba@xxxxxxxxxx>, <linux-afs@xxxxxxxxxxxxxxxxxxx>, <linux-hams@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-nfs@xxxxxxxxxxxxxxx>, <linux-rdma@xxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <linux-sctp@xxxxxxxxxxxxxxx>, <linux-wpan@xxxxxxxxxxxxxxx>, <linux-x25@xxxxxxxxxxxxxxx>, <lucien.xin@xxxxxxxxx>, <lvs-devel@xxxxxxxxxxxxxxx>, <marc.dionne@xxxxxxxxxxxx>, <marcelo.leitner@xxxxxxxxx>, <martineau@xxxxxxxxxx>, <matttbe@xxxxxxxxxx>, <mcgrof@xxxxxxxxxx>, <miquel.raynal@xxxxxxxxxxx>, <mptcp@xxxxxxxxxxxxxxx>, <ms@xxxxxxxxxx>, <neilb@xxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <netfilter-devel@xxxxxxxxxxxxxxx>, <pablo@xxxxxxxxxxxxx>, <ralf@xxxxxxxxxxxxxx>, <razor@xxxxxxxxxxxxx>, <rds-devel@xxxxxxxxxxxxxx>, <roopa@xxxxxxxxxx>, <stefan@xxxxxxxxxxxxxxxxxx>, <steffen.klassert@xxxxxxxxxxx>, <tipc-discussion@xxxxxxxxxxxxxxxxxxxxx>, <tom@xxxxxxxxxx>, <tonylu@xxxxxxxxxxxxxxxxx>, <trond.myklebust@xxxxxxxxxxxxxxx>, <wenjia@xxxxxxxxxxxxx>, <ying.xue@xxxxxxxxxxxxx>
From: Joel Granados <j.granados@xxxxxxxxxxx>
Date: Tue, 16 Apr 2024 14:32:12 +0200
On Tue, Apr 16, 2024 at 10:18:42AM +0200, Paolo Abeni wrote:
> On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote:
> > From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@xxxxxxxxxx>
> > Date: Fri, 12 Apr 2024 16:48:29 +0200
> > > From: Joel Granados <j.granados@xxxxxxxxxxx>
...
> > >  net/rxrpc/sysctl.c                  | 1 -
> > >  net/sctp/sysctl.c                   | 6 +-----
> > >  net/smc/smc_sysctl.c                | 1 -
> > >  net/sunrpc/sysctl.c                 | 1 -
> > >  net/sunrpc/xprtrdma/svc_rdma.c      | 1 -
> > >  net/sunrpc/xprtrdma/transport.c     | 1 -
> > >  net/sunrpc/xprtsock.c               | 1 -
> > >  net/tipc/sysctl.c                   | 1 -
> > >  net/unix/sysctl_net_unix.c          | 1 -
> > >  net/x25/sysctl_net_x25.c            | 1 -
> > >  net/xfrm/xfrm_sysctl.c              | 5 +----
> > >  35 files changed, 20 insertions(+), 81 deletions(-)
> > 
> > You may want to split patch based on subsystem or the type of changes
> > to make review easier.
> 
> I agree with Kuniyuki. I think the x25 chunks can me moved in the last
> patch, and at least sunrpc and rds could go in separate patches,
> possibly even xfrm and smc.

No problem. I'll put x25 and ax.25 patches together into one commit.
Thx

Best

-- 

Joel Granados

Attachment: signature.asc
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>