LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH ipvsadm v3 0/5] Debian package fixes

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH ipvsadm v3 0/5] Debian package fixes
Cc: Jeremy Sowden <azazel@xxxxxxxxxx>, LVS Devel <lvs-devel@xxxxxxxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxx>
Date: Sat, 18 Jan 2025 08:52:11 +0000
On Thu, Jan 16, 2025 at 08:44:28PM +0200, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Wed, 15 Jan 2025, Jeremy Sowden wrote:
> 
> > The Debian package of ipvsadm carries a few patches.  Some of them have
> > been around for years.  None of them is specific to Debian, so I'm
> > forwarding them upstream.
> > 
> > Patch 1 bumps the maximum weight accepted by ipvsadm.
> > Patch 2 fixes an unclear usage error message.
> > Patches 3-5 make some improvements to the Makefiles.
> > 
> > Changes since v2:
> > 
> > * Reformat the commit messages of patches 1, 2 & 5 according to the
> >   kernel's preferred patch format.
> > 
> > Changes since v1:
> > 
> > * The previous version of patch 2 changed the logic of the option parsing
> >   in such a way that using `-M` after `-6` no longer worked correctly.
> >   Thisversion just rewords the error message.
> > 
> > Jeremy Sowden (5):
> >   ipvsadm: increase maximum weight value
> >   ipvsadm: fix ambiguous usage error message
> >   Use variable for pkg-config in Makefiles
> >   Support environmental and command-line `*FLAGS` variable in Makefiles
> >   Make sure libipvs.a is built before ipvsadm
> 
>       Patchset looks good to me, thanks!
> 
> Acked-by: Julian Anastasov <ja@xxxxxx>
> 
>       Simon, please apply to the ipvsadm tree!

Thanks Jeremy and Julian, applied.

- Make sure libipvs.a is built before ipvsadm
  
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/3c9cdaef8216
- Support environmental and command-line `*FLAGS` variable in Makefiles
  
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/98d83badc6d7
- Use variable for pkg-config in Makefiles
  
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/0d5e6cdae6ab
- ipvsadm: fix ambiguous usage error message
  
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/fd1836223ab5
- ipvsadm: increase maximum weight value
  
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/78b786958803



<Prev in Thread] Current Thread [Next in Thread>