LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 00/36] treewide: remove conditional returns with no effect

To: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>
Subject: Re: [PATCH 00/36] treewide: remove conditional returns with no effect
Cc: Julia.Lawall@xxxxxxxx, Alex Deucher <alexander.deucher@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>, David Airlie <airlied@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Hans de Goede <hansg@xxxxxxxxxx>, Hans Verkuil <hverkuil@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, "Joerg Roedel (AMD)" <joro@xxxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Linus Walleij <linusw@xxxxxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Matthew Sakai <msakai@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Michael Turquette <mturquette@xxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>, Nicolas Palix <nicolas.palix@xxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Ping-Ke Shih <pkshih@xxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Sebastian Reichel <sre@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Simona Vetter <simona@xxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Thomas Renninger <trenn@xxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Tvrtko Ursulin <tursulin@xxxxxxxxxxx>, Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Yazen Ghannam <Yazen.Ghannam@xxxxxxx>, cocci@xxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-rtc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-sound@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, nouveau@xxxxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Fri, 24 Jul 2026 14:48:22 -0700
On Fri, 24 Jul 2026 03:45:02 +0900 Sang-Heon Jeon wrote:
> Patch 1 adds a Coccinelle script that matches the pattern, including
> negation and constant-comparison variants. Where a local variable is
> assigned right before the check, the assignment and the two returns
> turn into a single return of the assigned expression.

Huh, I thought we already had such script. Various script children have
been sending such "cleanups" in the past.

> Patches 2-36 are generated by the script, with hand fixes to restore
> unexpectedly removed comments and to fix the formatting checkpatch.pl
> complained about.

Please post patches 4,7,8,9 as a separate series. Since you only CCed
netdev on subset of the series patchwork thinks there are patches
missing and doesn't kick off any CI.


<Prev in Thread] Current Thread [Next in Thread>