LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

[PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

To: Simon Horman <horms@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>
Subject: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps
Cc: linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Mon, 4 Jul 2022 21:24:46 +0200
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
 net/netfilter/ipvs/ip_vs_mh.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
index da0280cec506..e3d7f5c879ce 100644
--- a/net/netfilter/ipvs/ip_vs_mh.c
+++ b/net/netfilter/ipvs/ip_vs_mh.c
@@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
                return 0;
        }
 
-       table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
-                       sizeof(unsigned long), GFP_KERNEL);
+       table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
        if (!table)
                return -ENOMEM;
 
@@ -227,7 +226,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
        }
 
 out:
-       kfree(table);
+       bitmap_free(table);
        return 0;
 }
 
-- 
2.34.1


<Prev in Thread] Current Thread [Next in Thread>