LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [patch] ipvs: off by one in set_sctp_state()

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [patch] ipvs: off by one in set_sctp_state()
Cc: Julian Anastasov <ja@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, netfilter@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Moahn Reddy <mohanreddykv@xxxxxxxxx>
Date: Mon, 22 Apr 2013 15:19:24 +0530
Hi Dan,

I am not saying that that is not a problem. Yes, we need to fix that array issue. I just said that I thought 0 to 254 enough at that time.

Thanks,
Mohan

On Monday 22 April 2013 03:00 PM, Dan Carpenter wrote:
On Mon, Apr 22, 2013 at 02:47:10PM +0530, Moahn Reddy wrote:
Hi,

I see there is no problem in the code regarding the state change.
And the thing why I took 255 in the sctp_events array is that as per
the sctp specification, the 255 message is reserved, so I thought 0
to 254 messages are enough.
The issue is can chunk_type in set_sctp_state() be 255?  How is
this prevented in the code?

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>