|
Hey Simon
On 01/29/2015 05:02 PM, Simon Horman wrote:
Hi Alex,
when you say "blow" what exactly happens? Does the kernel panic?
Assuming this is a bug fix could you provide some information
on when the problem was introduced? The reason is to facilitate
backporting to stable.
The kernel panics upon a garbage value dereference. ip6_skb_dst_mtu
features the following code:
static inline int ip6_skb_dst_mtu(struct sk_buff *skb)
{
struct ipv6_pinfo *np = skb->sk ? inet6_sk(skb->sk) : NULL;
return (np && np->pmtudisc >= IPV6_PMTUDISC_PROBE) ?
skb_dst(skb)->dev->mtu : dst_mtu(skb_dst(skb));
}
inet6_sk(skb->sk) expands to
inet_sk(skb->sk)->pinet6 which expands to
((struct inet_sock*)skb->sk)->pinet6
Because skb->sk is not actually an inet_sock, dereferencing at such is
nonsense and gives you a bunch of fields as a pointer, which is totally
bogus. The dereference into the structure to retrieve pmtudisc causes a
kernel panic after that.
We found this with our 3.10 porting effort (from 3.2). This failure was
introduced with early_demux in c7109986d "ipv6: Early TCP socket demux"
(2012-07-26) and has been present since. The underlying problem has
existed forever, but it wasn't possible to trigger it (AFAICT) prior to
that.
In terms of stable kernels, I believe 3.10 needs to be patched but 3.4
does not.
Thanks,
--
Alex Gartrell <agartrell@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
| 