lvs-devel
|
To: | Simon Horman <horms@xxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> |
---|---|
Subject: | Re: [PATCH nf-next 1/2] ipvs: Remove possibly unused variable from ip_vs_out |
Cc: | lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, David Ahern <dsa@xxxxxxxxxxxxxxxxxxx> |
From: | Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> |
Date: | Wed, 7 Oct 2015 16:58:47 +0300 |
Hello. On 10/7/2015 8:23 AM, Simon Horman wrote: From: David Ahern <dsa@xxxxxxxxxxxxxxxxxxx> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if CONFIG_IP_VS_IPV6 is not enabled: ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’: ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’ [-Wunused-variable] After the net refactoring there is only 1 user; push the reference to the 1 user. While the line length slightly exceeds 80 it seems to be the best change. Fixes: 1b75097dd7a26("ipvs: Pass ipvs into ip_vs_out") Minor nit: missing space before (. Could be probbably fixed while applying... Signed-off-by: David Ahern <dsa@xxxxxxxxxxxxxxxxxxx> Acked-by: Julian Anastasov <ja@xxxxxx> [horms: updated subject] Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html |
<Prev in Thread] | Current Thread | [Next in Thread> |
---|---|---|
|
Previous by Date: | Re: [PATCH net-next 01/15] ipv4: Fix ip_local_out_sk by passing the sk into __ip_local_out_sk, Sergei Shtylyov |
---|---|
Next by Date: | Re: [Help needed] Kernel level, OSI layers 2-3 Network driver developments, anyone in Northwest US region ?, John D Allen, Leveridge Systems INC |
Previous by Thread: | [PATCH nf-next 1/2] ipvs: Remove possibly unused variable from ip_vs_out, Simon Horman |
Next by Thread: | Re: [Help needed] Kernel level, OSI layers 2-3 Network driver developments, anyone in Northwest US region ?, John D Allen, Leveridge Systems INC |
Indexes: | [Date] [Thread] [Top] [All Lists] |