|  | 
lvs-devel
 | 
| To: | horms@xxxxxxxxxxxx, ja@xxxxxx, davem@xxxxxxxxxxxxx, dsahern@xxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx | 
|---|---|
| Subject: | [net] Question about ipvs->sysctl_sync_threshold and READ_ONCE | 
| Cc: | netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, chenyuan0y@xxxxxxxxx | 
| From: | Zijie Zhao <zzjas98@xxxxxxxxx> | 
| Date: | Tue, 19 Mar 2024 17:49:19 -0500 | 
| Dear IPVS maintainers,We encountered an unusual usage of sysctl parameter while analyzing kernel source code. 
In include/net/ip_vs.h, line 1062 - 1070:
```
static inline int sysctl_sync_threshold(struct netns_ipvs *ipvs)
{
        return ipvs->sysctl_sync_threshold[0];
}
static inline int sysctl_sync_period(struct netns_ipvs *ipvs)
{
        return READ_ONCE(ipvs->sysctl_sync_threshold[1]);
}
```
Here, sysctl_sync_threshold[1] is accessed behind `READ_ONCE`, but 
sysctl_sync_threshold[0] is not. Should sysctl_sync_threshold[0] also be 
guarded by `READ_ONCE`?Please kindly let us know if we missed any key information and this is actually intended. We appreciate your information and time! Thanks! Links to the code: https://elixir.bootlin.com/linux/v6.8.1/source/include/net/ip_vs.h#L1064 https://elixir.bootlin.com/linux/v6.8.1/source/include/net/ip_vs.h#L1069 Best, Zijie | 
| <Prev in Thread] | Current Thread | [Next in Thread> | 
|---|---|---|
| 
 | ||
| Previous by Date: | Re: [PATCH 11/11] sysctl: treewide: constify the ctl_table argument of handlers, Dave Chinner | 
|---|---|
| Next by Date: | Re: [net] Question about ipvs->sysctl_sync_threshold and READ_ONCE, Jason Xing | 
| Previous by Thread: | [PATCH 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers, Thomas Weißschuh | 
| Next by Thread: | Re: [net] Question about ipvs->sysctl_sync_threshold and READ_ONCE, Jason Xing | 
| Indexes: | [Date] [Thread] [Top] [All Lists] |