lvs-devel
|
To: | David Laight <David.Laight@xxxxxxxxxx> |
---|---|
Subject: | Re: [PATCH net] ipvs: Fix clamp() order in ip_vs_conn_init() |
Cc: | Julian Anastasov <ja@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, "netfilter-devel@xxxxxxxxxxxxxxx" <netfilter-devel@xxxxxxxxxxxxxxx>, "coreteam@xxxxxxxxxxxxx" <coreteam@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx> |
From: | Dan Carpenter <dan.carpenter@xxxxxxxxxx> |
Date: | Wed, 11 Dec 2024 18:49:06 +0300 |
On Wed, Dec 11, 2024 at 02:27:06PM +0000, David Laight wrote: > From: Dan Carpenter > > Sent: 11 December 2024 13:17 > > > > We recently added some build time asserts to detect incorrect calls to > > clamp and it detected this bug which breaks the build. The variable > > in this clamp is "max_avail" and it should be the first argument. The > > code currently is the equivalent to max = max(max_avail, max). > > The fix is correct but the description above is wrong. Aw yes, it's max = min(max_avail, max); I'll resend. regards, dan carpenter |
<Prev in Thread] | Current Thread | [Next in Thread> |
---|---|---|
|
Previous by Date: | RE: [PATCH net] ipvs: Fix clamp() order in ip_vs_conn_init(), David Laight |
---|---|
Next by Date: | [PATCH v2 net] ipvs: Fix clamp() order in ip_vs_conn_init(), Dan Carpenter |
Previous by Thread: | RE: [PATCH net] ipvs: Fix clamp() order in ip_vs_conn_init(), David Laight |
Next by Thread: | RE: [PATCH net] ipvs: Fix clamp() order in ip_vs_conn_init(), Julian Anastasov |
Indexes: | [Date] [Thread] [Top] [All Lists] |