|
Hi,
I have updated the code and generated the patch, according to your indications.
On Tue, Jul 14, 2015 at 10:11 PM, Julian Anastasov <ja@xxxxxx> wrote:
>
> Hello,
>
> On Tue, 14 Jul 2015, rhadoo.io88 wrote:
>
>> Unfortunately i was not aware of the FO scheduler, i looked it up just
>> now...indeed you could get similar behavior with FO scheduler and
>> proper thresholds.
>> The only trouble with that is that i can't set the thresholds from
>> within ldirectord , so i won't be able to keep all the config in one
>> place, and that upper threshold seems to take into account all
>> connections ( active and inactive) , that making the upper limit a bit
>> vague.
>> i think this approach has the advantage of keeping all the config in
>> one place, having the weight set at the actual number of active
>> connections the node can handle whilst still allowing to have
>> thresholds on the total connections.
>
> OK. But you have to update this scheduler because
> it is based on old code. You can use ip_vs_fo.c for
> reference. You have to fix any coding style warnings by using
> scripts/checkpatch.pl --strict /tmp/your.patch
> You can check Documentation/CodingStyle for reference.
> You can add comment that this scheduler can be used
> for TCP/SCTP but not for UDP because it uses only the
> activeconns.
>
> Your patch should include also changes for Kconfig
> and Makefile.
>
> Also, the 'curentw = atomic_read(&dest->weight);'
> can be used early to read the weight only once.
>
> Regards
>
> --
> Julian Anastasov <ja@xxxxxx>
addovf.patch
Description: Text Data
|
