LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs: Remove possibly unused net variable from ip_vs_out

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH] ipvs: Remove possibly unused net variable from ip_vs_out
Cc: Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netdev <netdev@xxxxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
From: Cong Wang <cwang@xxxxxxxxxxxxxxxx>
Date: Tue, 6 Oct 2015 16:27:35 -0700
On Tue, Oct 6, 2015 at 11:24 AM, Julian Anastasov <ja@xxxxxx> wrote:
>
>         Hello,
>
> On Tue, 6 Oct 2015, Simon Horman wrote:
>
>> Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and
>> ip_vs_in_icmp_v6") the net variable in ip_vs_out() appears to be unused
>> unless CONFIG_IP_VS_IPV6 is set. To resolve this remove the net variable
>> and dereference net asneeded.
>>
>> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
>
>         Both patches look good to me
>
> Acked-by: Julian Anastasov <ja@xxxxxx>
>

David sent a same patch earlier:

http://www.spinics.net/lists/netdev/msg345887.html
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>