Re: [PATCH] ipvs: use explicitly signed chars

lvs-devel

Re: [PATCH] ipvs: use explicitly signed chars

To:	"Jason A. Donenfeld" <Jason@xxxxxxxxx>
Subject:	Re: [PATCH] ipvs: use explicitly signed chars
Cc:	netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Julian Anastasov <ja@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
From:	Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date:	Wed, 2 Nov 2022 09:26:52 +0100

On Wed, Oct 26, 2022 at 02:32:16PM +0200, Jason A. Donenfeld wrote:
> The `char` type with no explicit sign is sometimes signed and sometimes
> unsigned. This code will break on platforms such as arm, where char is
> unsigned. So mark it here as explicitly signed, so that the
> todrop_counter decrement and subsequent comparison is correct.

Applied, thanks

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] ipvs: use explicitly signed chars, Jason A. Donenfeld Re: [PATCH] ipvs: use explicitly signed chars, Pablo Neira Ayuso <=

Previous by Date:	Re: [PATCH] ipvs: use explicitly signed chars, Jason A. Donenfeld
Next by Date:	Re: [RFC][PATCH v2 19/31] timers: net: Use del_timer_shutdown() before freeing timer, Steven Rostedt
Previous by Thread:	Re: [PATCH] ipvs: use explicitly signed chars, Jason A. Donenfeld
Next by Thread:	Re: [RFC][PATCH v2 19/31] timers: net: Use del_timer_shutdown() before freeing timer, Steven Rostedt
Indexes:	[Date] [Thread] [Top] [All Lists]