Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set

lvs-devel

Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl()

To:	Julian Anastasov <ja@xxxxxx>
Subject:	Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl()
Cc:	Li Qiong <liqiong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, Yu Zhe <yuzhe@xxxxxxxxxxxx>
From:	Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date:	Tue, 13 Dec 2022 12:28:24 +0100

On Mon, Dec 12, 2022 at 04:20:41PM +0200, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Mon, 12 Dec 2022, Li Qiong wrote:
> 
> > It is better to return the default switch case with
> > '-EINVAL', in case new commands are added. otherwise,
> > return a uninitialized value of ret.
> > 
> > Signed-off-by: Li Qiong <liqiong@xxxxxxxxxxxx>
> > Reviewed-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
>       Change looks correct to me for -next, thanks!
> 
> Acked-by: Julian Anastasov <ja@xxxxxx>

Applied, thanks.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), Li Qiong Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), Simon Horman Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), Dan Carpenter Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), liqiong Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), Dan Carpenter Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), Julian Anastasov Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl(), liqiong [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl(), Li Qiong Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl(), Julian Anastasov Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl(), Pablo Neira Ayuso <=

Previous by Date:	Re: [PATCH net-next] ipvs: fix type warning in do_div() on 32 bit, Pablo Neira Ayuso
Next by Date:	[linux-next:master] BUILD REGRESSION 39ab32797f072eaf86b1faa7384ac73450684110, kernel test robot
Previous by Thread:	Re: [PATCH v2] ipvs: add a 'default' case in do_ip_vs_set_ctl(), Julian Anastasov
Next by Thread:	Re: [PATCHv7 0/6] ipvs: Use kthreads for stats, Pablo Neira Ayuso
Indexes:	[Date] [Thread] [Top] [All Lists]