LVS
lvs-devel
[Top] [All Lists]
Google
 
Web LinuxVirtualServer.org
<prev [Date] next> <prev [Thread] next>

Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy

from [Simon Horman] [Permanent Link]
To: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy
Cc: linux-kernel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxx>
Date: Fri, 19 Aug 2022 11:50:01 +0200 
On Thu, Aug 18, 2022 at 11:02:24PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: 
> https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@xxxxxxxxxxxxxx/
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks Wolfram,

FWIIW, for the IPVS portion:

Reviewed-by: Simon Horman <horms@xxxxxxxxxxxx>

> ---
>  net/netfilter/ipset/ip_set_core.c |  4 ++--
>  net/netfilter/ipvs/ip_vs_ctl.c    |  8 ++++----
>  net/netfilter/nf_log.c            |  4 ++--
>  net/netfilter/nf_tables_api.c     |  2 +-
>  net/netfilter/nft_osf.c           |  2 +-
>  net/netfilter/x_tables.c          | 20 ++++++++++----------
>  net/netfilter/xt_RATEEST.c        |  2 +-
>  7 files changed, 21 insertions(+), 21 deletions(-)

...
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy, Florian Westphal
Next by Date:  [PATCH] ipvs: add a sysctl switch to control ipvs to bypass OUTPUT chain or not, longguang.yue
Previous by Thread:  Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy, Florian Westphal
Next by Thread:  [PATCH] ipvs: add a sysctl switch to control ipvs to bypass OUTPUT chain or not, longguang.yue
Indexes:  [Date] [Thread] [Top] [All Lists]